-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FX-4053] create codemods for RTE #3657
feat: [FX-4053] create codemods for RTE #3657
Conversation
🦋 Changeset detectedLatest commit: 4975888 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@toptal-bot run package:alpha-release |
Your alpha package is ready 🎉 |
@toptal-anvil ping reviewers |
1 similar comment
@toptal-anvil ping reviewers |
@@ -28,7 +28,7 @@ const findFilesInMonorepo = () => | |||
execaSync('find', [ | |||
'.', | |||
'-name', | |||
'*.tsx', | |||
'*.ts*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it used to take only TSX files
@@ -105,6 +106,7 @@ export const run = () => { | |||
|
|||
Options | |||
--parser-config Add parser config | |||
--run-in-band Run serially in the current process (default: false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have to execute this codemod
sequentially
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
packages/picasso-codemod/src/v36.0.0/__testfixtures__/imports.output.tsx
Show resolved
Hide resolved
packages/picasso-codemod/src/v36.0.0/__testfixtures__/imports.output.tsx
Show resolved
Hide resolved
* chore: create codemods for rte * chore: adjust codemod * chore: update eslint rules for codemod * chore: update eslintignore * chore: update prettier ignore * chore: update version
* feat: move rich text editor to a separate package * chore: rebase master branch * chore: fix tests * feat: [FX-4053] create codemods for RTE (#3657) * chore: create codemods for rte * chore: adjust codemod * chore: update eslint rules for codemod * chore: update eslintignore * chore: update prettier ignore * chore: update version * chore: update the changeset * chore: update changeset
FX-4053
Description
Create codemods for RTE migration to a separate package.
How to test
@toptal/picasso-codemod
RUN
Checked in Staff Portal: https://github.com/toptal/staff-portal/pull/10570
Development checks
PR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?